Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jsii): allow specifying baseUrl and paths in tsconfig.json #3662

Merged
merged 1 commit into from
Jul 18, 2022

Conversation

RomainMuller
Copy link
Contributor

Allow user control of the baseUrl and paths compiler options in
tsconfig.json via the jsii.tsc stanza in package.json.

Fixes #865


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Allow user control of the `baseUrl` and `paths` compiler options in
`tsconfig.json` via the `jsii.tsc` stanza in `package.json`.

Fixes #865
@RomainMuller RomainMuller self-assigned this Jul 18, 2022
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jul 18, 2022
@RomainMuller RomainMuller requested a review from a team July 18, 2022 12:57
@mergify
Copy link
Contributor

mergify bot commented Jul 18, 2022

Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it!

@mergify mergify bot added the pr/ready-to-merge This PR is ready to be merged. label Jul 18, 2022
@mergify
Copy link
Contributor

mergify bot commented Jul 18, 2022

Merging (with squash)...

1 similar comment
@mergify
Copy link
Contributor

mergify bot commented Jul 18, 2022

Merging (with squash)...

@mergify mergify bot merged commit 7eb11b7 into main Jul 18, 2022
@mergify mergify bot deleted the rmuller/support-ts-paths branch July 18, 2022 13:59
@mergify mergify bot removed the pr/ready-to-merge This PR is ready to be merged. label Jul 18, 2022
@heiba heiba mentioned this pull request Jul 22, 2022
4 tasks
@shellscape
Copy link

@RomainMuller I'm not able to find this in the changelogs (my apologies if it's there and I missed it) and I can't get this feature working as per #865 and the lean docs around setting jsii.tsc in package.json. Has this been released to v2?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeScript path aliasses
3 participants