feat(jsii): enforce enum names to be UPPER_CASE

README.md

@@ -21,7 +21,7 @@ like any other class.
 
 > NOTE: Due to performance of the hosted JavaScript engine and marshaling costs,
 __jsii__ modules are likely to be used for development and build tools, as
-oppose to performance-sensitive runtime behavior.
+opposed to performance-sensitive runtime behavior.
 
 From Java:
 

packages/jsii-calc-lib/lib/index.ts

@@ -95,8 +95,8 @@ export interface StructWithOnlyOptionals {
  * See awslabs/jsii#138
  */
 export enum EnumFromScopedModule {
-    Value1,
-    Value2
+    VALUE1,
+    VALUE2
 }
 
 /**

packages/jsii/lib/validator.ts

@@ -54,6 +54,7 @@ export type ValidationFunction = (validator: Validator,
 function _defaultValidations(): ValidationFunction[] {
     return [
         _typeNamesMustUsePascalCase,
+        _enumMembersMustUserUpperSnakeCase,
         _memberNamesMustUseCamelCase,
         _staticConstantNamesMustUseUpperSnakeCase,
         _memberNamesMustNotLookLikeJavaGettersOrSetters,
@@ -70,6 +71,19 @@ function _defaultValidations(): ValidationFunction[] {
         }
     }
 
+    function _enumMembersMustUserUpperSnakeCase(_: Validator, assembly: spec.Assembly, diagnostic: DiagnosticEmitter) {
+        for (const type of _allTypes(assembly)) {
+            if (!spec.isEnumType(type)) { continue; }
+
+            for (const member of type.members) {
+                if (member.name && member.name !== Case.constant(member.name)) {
+                    diagnostic(ts.DiagnosticCategory.Error,
+                               `Enum members must use TRUMP_CASE: ${member.name}`);
+                }
+            }
+        }
+    }
+
     function _memberNamesMustUseCamelCase(_: Validator, assembly: spec.Assembly, diagnostic: DiagnosticEmitter) {
         for (const member of _allMembers(assembly)) {
             if (member.static && (member as spec.Property).const) { continue; }

packages/jsii/test/negatives/neg.enum-name.1.ts

@@ -1,6 +1,6 @@
 ///!MATCH_ERROR: Type names must use PascalCase: myEnum
 
 export enum myEnum {
-    Foo,
-    Goo
+    FOO,
+    GOO
 }

packages/jsii/test/negatives/neg.enum-name.2.ts

@@ -1,6 +1,6 @@
 ///!MATCH_ERROR: Type names must use PascalCase: My_Enum
 
 export enum My_Enum {
-    Foo,
-    Goo
+    FOO,
+    GOO
 }

packages/jsii/test/test.enums.ts

@@ -8,16 +8,16 @@ export = {
   async 'test parsing enum with two members and no values'(test: Test) {
     const assembly = await sourceToAssemblyHelper(`
       export enum Foo {
-        Bar,
-        Baz
+        BAR,
+        BAZ
       }
     `);
 
     test.deepEqual(assembly.types!['testpkg.Foo'] , {
       assembly: 'testpkg',
       fqn: 'testpkg.Foo',
       kind: 'enum',
-      members: [{ name: 'Bar' }, { name: 'Baz' }],
+      members: [{ name: 'BAR' }, { name: 'BAZ' }],
       locationInModule: { filename: 'index.ts', line: 2 },
       name: 'Foo'
     });
@@ -29,16 +29,16 @@ export = {
   async 'test parsing enum with two members and assigned values'(test: Test) {
     const assembly = await sourceToAssemblyHelper(`
       export enum Foo {
-        Bar = 'Bar',
-        Baz = 'Baz'
+        BAR = 'Bar',
+        BAZ = 'Baz'
       }
     `);
 
     test.deepEqual(assembly.types!['testpkg.Foo'] , {
       assembly: 'testpkg',
       fqn: 'testpkg.Foo',
       kind: 'enum',
-      members: [{ name: 'Bar' }, { name: 'Baz' }],
+      members: [{ name: 'BAR' }, { name: 'BAZ' }],
       locationInModule: { filename: 'index.ts', line: 2 },
       name: 'Foo'
     });