fix(java): improve property override detection #692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous code only checked whether a methodd name was a get/setter by checking if it's name started by `get` or `set` and was at least 4 characters long. This is insufficient, as a method called `settings` would be misidentified. Changed to expect getters to have zero parameters, and setters to have exactly one parameter and to match a corresponding getter.
skinny85
approved these changes
Aug 9, 2019
packages/jsii-java-runtime/project/src/main/java/software/amazon/jsii/Util.java
Outdated
Show resolved
Hide resolved
packages/jsii-java-runtime/project/src/main/java/software/amazon/jsii/Util.java
Outdated
Show resolved
Hide resolved
packages/jsii-java-runtime/project/src/main/java/software/amazon/jsii/Util.java
Outdated
Show resolved
Hide resolved
|
I don't know what caused the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous code only checked whether a methodd name was a get/setter
by checking if it's name started by
getorsetand was at least 4characters long. This is insufficient, as a method called
settingswould be misidentified.
Changed to expect getters to have zero parameters, and setters to have
exactly one parameter and to match a corresponding getter.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.