Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pacmak): fix a couple of issues related to java generation #921

Merged
merged 2 commits into from
Oct 30, 2019

Conversation

RomainMuller
Copy link
Contributor

@RomainMuller RomainMuller commented Oct 30, 2019

Generating the aggregate POM could result in building a cyclic POM module tree,
as the aggregate POM file would then be replacing the module's own POM. This
stops aggregate-packaging single modules.

Also addresses an issue with the builder method names being generated
inconsistently across the Struct & Class builders, resulting in invalid
call forwarding being attempted.

Finally, it correctly generates overloads for Class builder methods.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

…tion

Generating the aggregate POM could result in building a cyclic POM module tree,
as the aggregate POM file would then be replacing the module's own POM. This
stops aggregate-packaging single modules.

Also addresses an issue with the builder method names being generated
inconsistently across the Struct & Class builders, resulting in invalid
call forwaring being attempted.
@RomainMuller RomainMuller requested a review from a team as a code owner October 30, 2019 18:09
@RomainMuller RomainMuller changed the title fix(pacmak): don't aggregate package single-packages & builder genera… fix(pacmak): fix a couple of issues related to java generation Oct 30, 2019
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Oct 30, 2019

Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it!

@mergify mergify bot added the pr/ready-to-merge This PR is ready to be merged. label Oct 30, 2019
@mergify mergify bot merged commit 5ad58c0 into master Oct 30, 2019
@mergify mergify bot deleted the rmuller/bugfix branch October 30, 2019 18:52
@mergify mergify bot removed the pr/ready-to-merge This PR is ready to be merged. label Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants