Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Found discrepancy in the details mentioned in the documentation regarding the file descriptor and memory leak bug. #4332

Closed
mooneeb opened this issue Jul 25, 2023 · 1 comment · Fixed by #4333
Labels
documentation Improvements or additions to documentation

Comments

@mooneeb
Copy link

mooneeb commented Jul 25, 2023

Description

How can the docs be improved?

Going through this Issue #4296, it mentions that there is a memory leak in Karpenter v0.29.1 which was fixed in v0.29.2. Someone also mentions within that ticket that rolling back to v0.29.0 actually resolves this issue.

However, going through the Upgrade guide for v0.29.0+, the warning says the follows:

Karpenter v0.29.0 contains a file descriptor and memory leak bug that leads to Karpenter getting OOMKilled and restarting at the point that it hits its memory or file descriptor limit. Karpenter >v0.29.1 fixes this leak.

My current assumption/understanding is that the information within the ticket is correct (i.e. bug is found in v0.29.1 and fixed in v0.29.2) and that this is just a small mistake within the documentation.

But please do let me know If my assumption/understanding is incorrect.

Thank you!

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment
@mooneeb mooneeb added the documentation Improvements or additions to documentation label Jul 25, 2023
@engedaam
Copy link
Contributor

@mooneeb your assumption is correct. The file descriptor leak was found in v0.29.1 and is fixed in v0.29.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants