Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Control instance userdata under provisioner field #885

Closed
amitde69 opened this issue Dec 1, 2021 · 6 comments
Closed

Control instance userdata under provisioner field #885

amitde69 opened this issue Dec 1, 2021 · 6 comments
Assignees
Labels
coming-soon Issues that we're working on and will be released soon feature New feature or request launch-templates Questions related to AWS launch templates

Comments

@amitde69
Copy link

amitde69 commented Dec 1, 2021

Tell us about your request
Currently we are working with cluster autoscaler in production, our only blocker from taking Karpenter to production is controlling the instance userdata when creating the provisioner resource.

Tell us about the problem you're trying to solve. What are you trying to do, and why is it hard?
It seems that the current implementation does not support custom userdata unless you’re using a custom launch-template.
Using a launch-template is not optimal because that defeats some of the purposes of Karpenter in terms of instance types/securitygroup/az balancing.

Are you currently working around this issue?
Currently its a blocker for us for using the tool
In production.

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment
@amitde69 amitde69 added the feature New feature or request label Dec 1, 2021
@akestner akestner added the launch-templates Questions related to AWS launch templates label Dec 6, 2021
@ellistarn
Copy link
Contributor

Hey @amitde69, we'd love to understand what about userdata you need. It's a challenging space that intermingles kubelet configuration and instance configuration. The more clear you can be about the use case, the better can find a solution that works cleanly with all use cases.

@amitde69
Copy link
Author

we are running on AWS and we want to avoid using AutoScalingGroups / Launch Templates entirely.

we are using chef/custom scripts to bootstrap all EKS nodes to install some prerequisites before joining the nodes into the cluster, so we have custom userdata configure for all the EC2 EKS nodes.

if we can configure the userdata in Karpenter objects, it will allow us to not relay on AutoScalingGroups / Launch Templates entirely and let Karpenter do all the thinking.

@ellistarn
Copy link
Contributor

Is it possible to install these prerequisites using a daemonset with root permissions?

@amitde69
Copy link
Author

amitde69 commented Jan 24, 2022

Not really because we are installing SSM agent on the nodes at start up, if the node fails to join the cluster then we wont have SSM access to debug it
but thats just one example, eventually decoupling Karpenter from the launch template sounds like the best option to me, to be able to configure all the instance options in the provisioner and let karpeneter to the rest for you.

@adjain131995
Copy link

Is there any plan of integrating the feature of providing user data in the provisions themselves instead of going ahead with the Launch templates?
This will solve multiple github issues and save us a lot of hassle of going via launch templates.

@suket22 suket22 self-assigned this Apr 18, 2022
@akestner akestner added the coming-soon Issues that we're working on and will be released soon label Jun 14, 2022
@ellistarn
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
coming-soon Issues that we're working on and will be released soon feature New feature or request launch-templates Questions related to AWS launch templates
Projects
None yet
Development

No branches or pull requests

5 participants