Skip to content

Commit

Permalink
Updated an inaccurate comment (#895)
Browse files Browse the repository at this point in the history
* Updated an inaccurate comment

* Included codegen

* PR comments
  • Loading branch information
ellistarn committed Dec 3, 2021
1 parent 58c2170 commit 6984094
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 16 deletions.
12 changes: 4 additions & 8 deletions charts/karpenter/crds/karpenter.sh_provisioners.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -35,14 +35,10 @@ spec:
type: object
spec:
description: ProvisionerSpec is the top level provisioner specification.
Provisioners launch nodes in response to pods where status.conditions[type=unschedulable,
status=true]. Node configuration is driven by through a combination
of provisioner specification (defaults) and pod scheduling constraints
(overrides). A single provisioner is capable of managing highly diverse
capacity within a single cluster and in most cases, only one should
be necessary. It's possible to define multiple provisioners. These provisioners
may have different defaults and can be specifically targeted by pods
using pod.spec.nodeSelector["karpenter.sh/provisioner-name"]=$PROVISIONER_NAME.
Provisioners launch nodes in response to pods that are unschedulable.
A single provisioner is capable of managing a diverse set of nodes.
Node properties are determined from a combination of provisioner and
pod scheduling constraints.
properties:
labels:
additionalProperties:
Expand Down
11 changes: 3 additions & 8 deletions pkg/apis/provisioning/v1alpha5/provisioner.go
Original file line number Diff line number Diff line change
Expand Up @@ -19,14 +19,9 @@ import (
)

// ProvisionerSpec is the top level provisioner specification. Provisioners
// launch nodes in response to pods where status.conditions[type=unschedulable,
// status=true]. Node configuration is driven by through a combination of
// provisioner specification (defaults) and pod scheduling constraints
// (overrides). A single provisioner is capable of managing highly diverse
// capacity within a single cluster and in most cases, only one should be
// necessary. It's possible to define multiple provisioners. These provisioners
// may have different defaults and can be specifically targeted by pods using
// pod.spec.nodeSelector["karpenter.sh/provisioner-name"]=$PROVISIONER_NAME.
// launch nodes in response to pods that are unschedulable. A single provisioner
// is capable of managing a diverse set of nodes. Node properties are determined
// from a combination of provisioner and pod scheduling constraints.
type ProvisionerSpec struct {
// Constraints are applied to all nodes launched by this provisioner.
Constraints `json:",inline"`
Expand Down

0 comments on commit 6984094

Please sign in to comment.