Add Ability to Specify Kubelet Configuration, specifically clusterDNS

[mikesir87]

1. Issue, if available:
Resolves #928

2. Description of changes:
Adds the ability to specify kubeletConfiguration, specifically the clusterDNS setting.

3. Does this change impact docs?

• Yes, PR includes docs updates
• Yes, issue opened: link to issue
• No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[netlify]

✔️ Deploy Preview for karpenter-docs-prod canceled.

🔨 Explore the source changes: 96965e8

🔍 Inspect the deploy log: https://app.netlify.com/sites/karpenter-docs-prod/deploys/61bc05699e363a0007119967

[ellistarn]

LGTM. I'm a bit tired -- can you get an approval from Suket just in case I'm missing anything?

[ellistarn]

Nice work, btw!

[mikesir87]

@suket22 Can you take a look? Thanks!

[mikesir87]

Rebased on top of latest to resolve conflict

[mikesir87]

Just noticed that there was a name mismatch between the JSON object and the Go type. So, fixing that (any chance that could be caught in a lint check?).

And @akestner - I saw the title change. I'm going to tweak it just a tiny bit because the names ended up being adjusted as we did the work and I neglected to go back and update the original description of changes. I've rectified my transgression 😄

[justinsnair]

@mikesir87

I have installed helm-chart v 0.5.5 which should have these changes however when trying to create a provisioner I am getting this error:

error: error validating "provisioner.yaml": error validating data: ValidationError(Provisioner.spec): unknown field "kubeletConfiguration" in sh.karpenter.v1alpha5.Provisioner.spec; if you choose to ignore these errors, turn validation off with --validate=false

Here is my provisioner:

apiVersion: karpenter.sh/v1alpha5
kind: Provisioner
metadata:
  name: default-provisioner
spec:
  kubeletConfiguration: 
    clusterDNS: ["redacted"]
  requirements:
    - key: karpenter.sh/capacity-type
      operator: In
      values: ["spot"]
  limits:
    resources:
      cpu: 500m
  provider:
    instanceProfile: "redacted"
  ttlSecondsAfterEmpty: 30

Am i missing something?

[mikesir87]

@justinsnair Did you install the chart as an upgrade to a previous version? If so, you'll need to update the CRD as Helm doesn't do CRD updates.

[justinsnair]

This was it. I knew this but totally slipped my mind.. Thanks for the reminder!