Restore ability to override Name tag on AWS #1211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for karpenter-docs-prod canceled. 🔨 Explore the source changes: 6b8b78f 🔍 Inspect the deploy log: https://app.netlify.com/sites/karpenter-docs-prod/deploys/61ef0e73eea6580007d1e6e9 |
ellistarn
changed the title
|
|
ellistarn
changed the title
bwagner5
requested changes
Jan 24, 2022
pkg/cloudprovider/aws/instance.go
Outdated
| }, | ||
| TagSpecifications: []*ec2.TagSpecification{{ | ||
| ResourceType: aws.String(ec2.ResourceTypeInstance), | ||
| Tags: constraints.GetTags(ctx, map[string]string{fmt.Sprintf("kubernetes.io/cluster/%s", injection.GetOptions(ctx).ClusterName): "owned"}), |
There was a problem hiding this comment.
constraints.Tags instead of GetTags?
ellistarn
force-pushed
the
944
branch
2 times, most recently
from
b64d725
to
c391db7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Issue, if available:
2. Description of changes:
3. How was this change tested?
4. Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.