Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix up github python scripts #1212

Merged
merged 2 commits into from
Jan 24, 2022
Merged

fix up github python scripts #1212

merged 2 commits into from
Jan 24, 2022

Conversation

bwagner5
Copy link
Contributor

1. Issue, if available:
N/A

2. Description of changes:

  • set issues Make target as phony
  • added requirements.txt with PyGithub dep and included a pip install -r requirements.txt to make issues
  • added output files to .gitignore
  • use python3 bin instead of plain python since some default to python2 (like on mac :) )
  • fix output filenames to include the date

3. How was this change tested?

4. Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: link to issue
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@netlify
Copy link

netlify bot commented Jan 24, 2022

✔️ Deploy Preview for karpenter-docs-prod canceled.

🔨 Explore the source changes: abc94e1

🔍 Inspect the deploy log: https://app.netlify.com/sites/karpenter-docs-prod/deploys/61ef1a4964b1c600075d9340

.gitignore Outdated
@@ -6,3 +6,4 @@ coverage.html
website/node_modules
website/resources
website/public
karpenter-*.csv
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why doesn't *.csv catch this?

ellistarn
ellistarn previously approved these changes Jan 24, 2022
@ellistarn ellistarn merged commit 0745ebf into aws:main Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants