Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update provisioning configuration docs #1307

Merged
merged 1 commit into from Feb 20, 2022
Merged

chore: update provisioning configuration docs #1307

merged 1 commit into from Feb 20, 2022

Conversation

robertd
Copy link
Contributor

@robertd robertd commented Feb 9, 2022

1. Issue, if available:

image

2. Description of changes:

3. How was this change tested?

4. Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: link to issue
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@netlify
Copy link

netlify bot commented Feb 9, 2022

✔️ Deploy Preview for karpenter-docs-prod ready!

🔨 Explore the source changes: f67b00e

🔍 Inspect the deploy log: https://app.netlify.com/sites/karpenter-docs-prod/deploys/62043cde7dcf470008ae7756

😎 Browse the preview: https://deploy-preview-1307--karpenter-docs-prod.netlify.app

@@ -85,7 +85,7 @@ To verify if this restriction affects you, run the following commands.
```bash
CLUSTER_VPC_ID="$(aws eks describe-cluster --name $CLUSTER_NAME --query cluster.resourcesVpcConfig.vpcId --output text)"

aws ec2 describe-security-groups --filters Name=vpc-id,Values=$CLUSTER_VPC_ID Name=tag-key,Values=kubernetes.io/cluster/$CLUSTER_NAME --query SecurityGroups[].[GroupName] --output text
aws ec2 describe-security-groups --filters Name=vpc-id,Values=$CLUSTER_VPC_ID Name=tag-key,Values=kubernetes.io/cluster/$CLUSTER_NAME --query 'SecurityGroups[].[GroupName]' --output text
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for submitting the change.
I ran the two command and I don't see any difference. Is there any reason that the single quotation marks are needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m getting an error on my Mac. I’ll update the OP with the screenshot once I get to my computer.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm using zsh... that's why.

image

@ellistarn ellistarn merged commit 3f7cf29 into aws:main Feb 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants