Fix cluster DNS IP format in Bottlerocket userdata #1389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bottlerocket, like AL2, also only supports a single cluster DNS IP. This change matches Bottlerocket behavior to the existing AL2 one.
|
✔️ Deploy Preview for karpenter-docs-prod canceled. 🔨 Explore the source changes: a534fbc 🔍 Inspect the deploy log: https://app.netlify.com/sites/karpenter-docs-prod/deploys/62150c13f5a4960007b8b215 |
bwagner5
reviewed
Feb 21, 2022
Co-authored-by: Brandon Wagner <bmwagner10@gmail.com>
|
Ah looks like there's a tiny formatting issue in that change, can you run: and commit the change that produces. Sorry about that! |
|
Hopefully this does the trick :) |
ellistarn
approved these changes
Feb 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Issue, if available:
Using Bottlerocket with
spec.kubeletConfiguration.clusterDNSin the provider will fail to generate valid user data ("[ip]"instead of"ip"), which leads to the nodes not becoming ready.2. Description of changes:
This change matches the Bottlerocket behavior to the AL2 one, where only the first IP will be picked into the option. Since Bottlerocket OS also only supports a single IP for that option this seems to be the only plausible way atm.
3. How was this change tested?
Built a custom controller image and used it in my own EKS cluster w/ IPv6 (where setting the cluster DNS is required). Used
spec.provider.amiFamily: Bottlerocket.4. Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.