Update AWS Provisioner docs w/ proper tag examples #1402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for karpenter-docs-prod ready! 🔨 Explore the source changes: ecf2b0e 🔍 Inspect the deploy log: https://app.netlify.com/sites/karpenter-docs-prod/deploys/6215594575c7d30007bcc5a2 😎 Browse the preview: https://deploy-preview-1402--karpenter-docs-prod.netlify.app |
bwagner5
changed the title
bwagner5
changed the title
ellistarn
reviewed
Feb 24, 2022
| @@ -0,0 +1 @@ | |||
| /{{ replace (chomp (delimit (first 2 (split .Page.RelPermalink "/")) "" "")) "preview" .Page.Site.Params.github_branch }}/ | |||
There was a problem hiding this comment.
Can we leave the slashes outside, e.g. /{{< githubRelRef > }}/
There was a problem hiding this comment.
We can, the reason I have it like this is to match the {{< relref >}} that we use for the versioned links for docs pages which includes the slashes.
ellistarn
approved these changes
Feb 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Issue, if available:
#1310
2. Description of changes:
karpenter.sh/discoverytags in examplesNameexample (it was using the id rather than name)3. How was this change tested?
4. Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.