add more linters to golangci-linters #1424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for karpenter-docs-prod canceled. 🔨 Explore the source changes: 47d4470 🔍 Inspect the deploy log: https://app.netlify.com/sites/karpenter-docs-prod/deploys/621e6e815f9a08000701cedc |
ellistarn
reviewed
Feb 28, 2022
| @@ -4,9 +4,6 @@ run: | |||
|
|
|||
| timeout: 5m | |||
|
|
|||
| build-tags: | |||
| - aws | |||
There was a problem hiding this comment.
Does this mean we're no longer checking the AWS code paths?
There was a problem hiding this comment.
No, the linters don't use build tags. I did a test to confirm by adding a bunch of if's which gocyclo picked up. Also checked goimports corrects code inside of the aws cloud provider.
ellistarn
approved these changes
Mar 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Issue, if available:
N/A
2. Description of changes:
linters-settingsblockmisspell,govet,gofmt,goimports, andgocycloto the golangci-linter config, and remove duplicated checks in the Makefile.awsbuild tagerr3. How was this change tested?
make verify4. Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.