tag volumes with the provider tags #1455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for karpenter-docs-prod canceled. 🔨 Explore the source changes: f6f6151 🔍 Inspect the deploy log: https://app.netlify.com/sites/karpenter-docs-prod/deploys/621fdcc38ba2e50008f01a50 |
ellistarn
reviewed
Mar 2, 2022
ellistarn
previously approved these changes
Mar 2, 2022
spring1843
previously approved these changes
Mar 2, 2022
Pass provider tags to CreateFleet for volumes as well. Fixes aws#1430
tzneal
force-pushed
the
pass-tags-to-volumes
branch
from
680b712
to
f6f6151
Compare
|
Incorporated feedback and re-tested live. |
ellistarn
approved these changes
Mar 2, 2022
|
Nice feature! Thank you! Can you follow up with a documentation change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass provider tags to CreateFleet for volumes as well.
1. Issue, if available:
#1430
2. Description of changes:
3. How was this change tested?
Configured a provisioner with tags and inspected the volumes created in the EC2 console to ensure that the tags were applied.
4. Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.