Add note to clarify this upgrading is about the OS #1463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for karpenter-docs-prod ready! 🔨 Explore the source changes: 8e7a34d 🔍 Inspect the deploy log: https://app.netlify.com/sites/karpenter-docs-prod/deploys/62210bc9aa744700081010ee 😎 Browse the preview: https://deploy-preview-1463--karpenter-docs-prod.netlify.app |
ellistarn
reviewed
Mar 3, 2022
bwagner5
reviewed
Mar 3, 2022
bwagner5
reviewed
Mar 3, 2022
ellistarn
reviewed
Mar 3, 2022
| @@ -72,7 +72,7 @@ For more details on how Karpenter deletes nodes, see [Deprovisioning nodes](../t | |||
| ### Upgrading nodes | |||
|
|
|||
| A straight-forward way to upgrade nodes is to set `ttlSecondsUntilExpired`. | |||
| Nodes will be terminated after a set period of time and will be replaced with newer nodes. | |||
| Nodes will be terminated after a set period of time and will be replaced with newer nodes using the latest [EKS Optimized AMI](https://docs.aws.amazon.com/eks/latest/userguide/eks-optimized-amis.html) or the AMI specified in the `$LATEST` version of your launch template. | |||
There was a problem hiding this comment.
note that it's not just EKSOptimized, it's any AMI (e.g. Bottlerocket)
There was a problem hiding this comment.
AL2, Ubuntu, Bottlerocket, and Windows are "EKS Optimized" AMI according to the link: https://docs.aws.amazon.com/eks/latest/userguide/eks-optimized-amis.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Issue, if available:
2. Description of changes:
This seems a bit vague, 'upgrade' could be interpreted in different ways including vertically scaling the nodes. This addition makes it clear that upgrading is about upgrading the operating system (i.e. the AMI) and only relevant when using AL2 and Bottlerocket.
3. How was this change tested?
4. Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.