Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add link to eks best practices guide for karpenter #1475

Merged
merged 1 commit into from
Mar 7, 2022

Conversation

bwagner5
Copy link
Contributor

@bwagner5 bwagner5 commented Mar 6, 2022

1. Issue, if available:
N/A

2. Description of changes:

  • Add eks best practices guide for Karpenter on the AWS landing page in Karpenter docs.

3. How was this change tested?

  • make website

4. Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: link to issue
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@netlify
Copy link

netlify bot commented Mar 6, 2022

✔️ Deploy Preview for karpenter-docs-prod ready!

🔨 Explore the source changes: b3f906d

🔍 Inspect the deploy log: https://app.netlify.com/sites/karpenter-docs-prod/deploys/622510bb317aa4000738bd77

😎 Browse the preview: https://deploy-preview-1475--karpenter-docs-prod.netlify.app

@bwagner5 bwagner5 requested a review from chrisnegus March 7, 2022 16:48
@ellistarn ellistarn merged commit ee4f9c8 into aws:main Mar 7, 2022
@stevehipwell
Copy link
Contributor

@bwagner5 the Karpenter section in the guide is great, but it would be really useful if the guide had the correct configuration to setup the event bridge rules for Karpenter embedded as the NTH docs aren't the clearest. Also the workshop NTH section seems to contradict the guide as it's using the DaemonSet mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants