Feat: Nodes are now owned by Provisioners, and will cascade on delete by default #1934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for karpenter-docs-prod canceled.
|
ellistarn
force-pushed
the
owners
branch
2 times, most recently
from
c11e277
to
0019cec
Compare
bwagner5
approved these changes
Jun 16, 2022
| @@ -169,6 +169,7 @@ func (p *Provisioner) getPods(ctx context.Context) ([]*v1.Pod, error) { | |||
| return pods, nil | |||
| } | |||
|
|
|||
| // nolint: gocyclo | |||
bwagner5
reviewed
Jun 16, 2022
| - apiGroups: [""] | ||
| resources: ["pods/binding", "pods/eviction"] |
This was referenced Jul 13, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1268 #1738
Description
Previously, when a provisioner was deleted, the nodes would be leaked and require manual cleanup. With this change, deletion of a provisioner will result in deletion of the nodes it launched. This aligns with the GitOps mental model.
Since this is a breaking change, this will trigger a minor version bump.
How was this change tested?
make test--cascade=orphan. See: https://kubernetes.slack.com/archives/CAR30FCJZ/p1655243575953659. Ownerreferences may still be removed via API if node orphaning is necessary.Does this change impact docs?
Release Note
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.