Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add instance-hypervisor as an AWS node label #1948

Merged
merged 2 commits into from Jun 16, 2022

Conversation

bwagner5
Copy link
Contributor

Fixes #

Description

  • Add instance-hypervisor label as an AWS node label so that you can filter for xen or nitro hypervisors.

How was this change tested?

  • make test
  • manually tested on an EKS cluster

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note

Add support for the AWS node label `karpenter.k8s.aws/instance-hypervisor` to select `nitro` or `xen` compatible instance types.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@bwagner5 bwagner5 requested a review from a team as a code owner June 16, 2022 16:33
@bwagner5 bwagner5 requested a review from tzneal June 16, 2022 16:33
@netlify
Copy link

netlify bot commented Jun 16, 2022

Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit ea348e3
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/62ab5fe876801a000afe2d3a
😎 Deploy Preview https://deploy-preview-1948--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@tzneal tzneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@bwagner5 bwagner5 merged commit d261f94 into aws:main Jun 16, 2022
@bwagner5 bwagner5 deleted the hypervisor-selection branch June 16, 2022 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants