New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Include all Provider fields in the AWSNodeTemplate CRD #1951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for karpenter-docs-prod canceled.
|
suket22
commented
Jun 16, 2022
ellistarn
reviewed
Jun 17, 2022
ellistarn
reviewed
Jun 17, 2022
ellistarn
reviewed
Jun 17, 2022
ellistarn
reviewed
Jun 17, 2022
ellistarn
reviewed
Jun 17, 2022
ellistarn
reviewed
Jun 17, 2022
Co-authored-by: Ellis Tarn <ellistarn@gmail.com>
Co-authored-by: Ellis Tarn <ellistarn@gmail.com>
ellistarn
approved these changes
Jun 20, 2022
This was referenced Jul 13, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As part of releasing custom UserData support, this moves all of the provider fields into ProviderRef as well. This should allow everyone to specify everything related to the AWS provider within the AWSNodeTemplate CRD.
Made a couple more changes while I was on this -
paths
toawsnodetemplate
which is the annotation kubebuilder is looking for to determine the plural name of the CRD. Anyone running a pre-release version of Karpenter should be unaffected as long as they update the charts. (new CRD works, and old provisioner yaml is fine).How was this change tested?
Tested a few things on this front -
Example Manifest to try this change out -
Does this change impact docs?
Docs will be added in a subsequent PR since this change is large enough as-is.
I'll need to add -
With that, a separate PR makes sense.
Release Note
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.