Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Add e2etesting to weighted provisioners feature #2324

Merged
merged 1 commit into from
Aug 19, 2022
Merged

test: Add e2etesting to weighted provisioners feature #2324

merged 1 commit into from
Aug 19, 2022

Conversation

jonathan-innis
Copy link
Contributor

Fixes #

Description

  • Adds e2etesting for weighting provisioners

How was this change tested?

  • make e2etests

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note

None

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@netlify
Copy link

netlify bot commented Aug 19, 2022 •
edited

✅ Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit 1367555
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/62ffc5ed7185300008105166
😎 Deploy Preview https://deploy-preview-2324--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@jonathan-innis jonathan-innis marked this pull request as ready for review August 19, 2022 17:18
@jonathan-innis jonathan-innis requested a review from a team as a code owner August 19, 2022 17:18
ellistarn
ellistarn approved these changes Aug 19, 2022
View reviewed changes
Copy link
Contributor

@ellistarn ellistarn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@jonathan-innis jonathan-innis merged commit 45abfa1 into aws:main Aug 19, 2022
@jonathan-innis jonathan-innis deleted the weighted-provsioner-e2etesting branch August 19, 2022 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ellistarn ellistarn ellistarn approved these changes

@bwagner5 bwagner5 Awaiting requested review from bwagner5 bwagner5 is a code owner automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonathan-innis @ellistarn