Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a bug where startuptaints weren't correctly injected into bootstrap #2327

Merged
merged 1 commit into from
Aug 19, 2022

Conversation

ellistarn
Copy link
Contributor

@ellistarn ellistarn commented Aug 19, 2022

Fixes #2286

Description

  • Include startup taints in bootstrap logic
  • Added tests for startup tests
  • Separated the aws tests for readability

How was this change tested?

  • make test
  • make e2etest

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ellistarn ellistarn requested a review from a team as a code owner August 19, 2022 18:56
@ellistarn ellistarn requested a review from tzneal August 19, 2022 18:56
@netlify
Copy link

netlify bot commented Aug 19, 2022

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 4d31c6d
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/62fff97fc952d2000978cb45

@ellistarn ellistarn changed the title [wip] Fix: Fixed a bug where startuptaints weren't correctly injected into bootstrap Fixed a bug where startuptaints weren't correctly injected into bootstrap Aug 19, 2022
Copy link
Contributor

@suket22 suket22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@ellistarn ellistarn merged commit 104576a into aws:main Aug 19, 2022
@ellistarn ellistarn deleted the 2286 branch August 19, 2022 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to get lease: leases.coordination.k8s.io "ip-10-50-145-143.ec2.internal" not found
2 participants