Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add evictionSoft support to kubeletConfiguration #2514

Merged
merged 3 commits into from
Oct 3, 2022
Merged

feat: Add evictionSoft support to kubeletConfiguration #2514

merged 3 commits into from
Oct 3, 2022

Conversation

jonathan-innis
Copy link
Contributor

@jonathan-innis jonathan-innis commented Sep 15, 2022 •
edited

Fixes #

Description

  • Adds evictionSoft support into kubeletConfiguration
  • This adds the fields evictionSoft, evictionSoftGracePeriod and evictionMaxPodGracePeriod
apiVersion: karpenter.sh/v1alpha5
kind: Provisioner
metadata:
  name: default
spec:
  ...
  kubeletConfiguration:
    evictionSoft:
      memory.available: "50%"
    evictionSoftGracePeriod:
      memory.available: 180s
    evictionMaxPodGracePeriod: 120

How was this change tested?

  • make test

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note

Add `evictionSoft` support into `kubeletConfiguration`

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jonathan-innis jonathan-innis requested a review from a team as a code owner September 15, 2022 19:57
@netlify
Copy link

netlify bot commented Sep 15, 2022 •
edited

✅ Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 53c982b
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/633b13157af7530009f4c054

@jonathan-innis jonathan-innis force-pushed the eviction-soft branch 6 times, most recently from ce79683 to b08bc78 Compare September 15, 2022 22:02
bwagner5
bwagner5 reviewed Sep 30, 2022
View reviewed changes
Copy link
Contributor

@bwagner5 bwagner5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! just a few minor nits! Overall, very nice!

pkg/apis/provisioning/v1alpha5/provisioner.go Outdated Show resolved Hide resolved
charts/karpenter/crds/karpenter.sh_provisioners.yaml Outdated Show resolved Hide resolved
pkg/apis/provisioning/v1alpha5/suite_test.go Outdated Show resolved Hide resolved
pkg/cloudprovider/aws/amifamily/bootstrap/eksbootstrap.go Outdated Show resolved Hide resolved
pkg/cloudprovider/aws/amifamily/bottlerocket.go Show resolved Hide resolved
pkg/cloudprovider/aws/amifamily/custom.go Outdated Show resolved Hide resolved
pkg/cloudprovider/aws/instancetype.go Outdated Show resolved Hide resolved
test/suites/integration/kubelet_config_test.go Show resolved Hide resolved
@jonathan-innis jonathan-innis force-pushed the eviction-soft branch 4 times, most recently from fa4c6fa to 40d1a9d Compare September 30, 2022 23:15
@jonathan-innis
Copy link
Contributor Author

Good comments! @bwagner5

bwagner5
bwagner5 previously approved these changes Sep 30, 2022
View reviewed changes
Copy link
Contributor

@bwagner5 bwagner5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! nice 🔥

bwagner5
bwagner5 approved these changes Oct 3, 2022
View reviewed changes
Copy link
Contributor

@bwagner5 bwagner5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch! and bonus points, is more readable now :D

@jonathan-innis jonathan-innis merged commit bbe41c3 into aws:main Oct 3, 2022
@jonathan-innis jonathan-innis deleted the eviction-soft branch October 3, 2022 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwagner5 bwagner5 bwagner5 approved these changes

@dewjam dewjam Awaiting requested review from dewjam dewjam is a code owner automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonathan-innis @bwagner5