test: Update WithOffset so that failures point to outer call to helper function
#2530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for karpenter-docs-prod canceled.
|
jonathan-innis
force-pushed
the
with-offset
branch
2 times, most recently
from
7dfc148
to
18adecc
Compare
jonathan-innis
force-pushed
the
with-offset
branch
2 times, most recently
from
49ec30c
to
c74f5c3
Compare
jonathan-innis
force-pushed
the
with-offset
branch
from
c74f5c3
to
9c0c2dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Description
WithOffsetoptions so that the caller function line number will be referenced on failure rather than just pointing to the inner failure in the helper function which may not be useful.How was this change tested?
TEST_FILTER=Integration make e2etestsDoes this change impact docs?
Release Note
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.