Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Disable leader election for webhooks #2563

Merged
merged 1 commit into from
Sep 29, 2022

Conversation

jonathan-innis
Copy link
Contributor

Fixes #2562

Description

  • Revert leader-election for webhooks with Karpenter in HA mode

How was this change tested?

  • Manual install of Karpenter

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note

None

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@netlify
Copy link

netlify bot commented Sep 28, 2022

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 671c24c
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/6334a003496fb80008d4ef53

njtran
njtran previously approved these changes Sep 28, 2022
Copy link
Contributor

@njtran njtran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! One nit for good measure

pkg/webhooks/webhooks.go Show resolved Hide resolved
Copy link
Contributor

@njtran njtran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT 🚢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Karpenter webhook fails to acquire leader-election lease
2 participants