Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use the SNAPSHOT_TAG env variable for application version when available #2575

Merged
merged 1 commit into from
Sep 30, 2022
Merged

fix: use the SNAPSHOT_TAG env variable for application version when available #2575

merged 1 commit into from
Sep 30, 2022

Conversation

spring1843
Copy link
Contributor

… the version from git

Fixes #

Description
Fixes the problem where the application version is not set properly in GA when the tag is not passed down to a workflow that runs on workflow dispatch.

How was this change tested?

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@spring1843 spring1843 requested a review from a team as a code owner September 30, 2022 23:23
@netlify
Copy link

netlify bot commented Sep 30, 2022

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 4559ae1
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/63377a64083fdc00092adbe1

@spring1843 spring1843 enabled auto-merge (squash) September 30, 2022 23:24
Copy link
Contributor

@bwagner5 bwagner5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spring1843 spring1843 merged commit 7480cd6 into aws:main Sep 30, 2022
@spring1843 spring1843 deleted the rm/fix-app-version-injection branch September 30, 2022 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants