Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't race when recording termination metrics #2635

Merged
merged 1 commit into from Oct 10, 2022
Merged

fix: don't race when recording termination metrics #2635

merged 1 commit into from Oct 10, 2022

Conversation

tzneal
Copy link
Contributor

@tzneal tzneal commented Oct 10, 2022

Description

How was this change tested?

  • Unit testing

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@tzneal tzneal requested a review from a team as a code owner October 10, 2022 12:28
@netlify
Copy link

netlify bot commented Oct 10, 2022 •
edited

✅ Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit 57dca01
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/63440fe2c7f7e2000802325f
😎 Deploy Preview https://deploy-preview-2635--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

bwagner5
bwagner5 approved these changes Oct 10, 2022
View reviewed changes
Copy link
Contributor

@bwagner5 bwagner5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tzneal tzneal merged commit c083242 into aws:main Oct 10, 2022
@tzneal tzneal deleted the fix-concurrent-write-in-termination-controller branch October 10, 2022 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwagner5 bwagner5 bwagner5 approved these changes

@spring1843 spring1843 Awaiting requested review from spring1843 spring1843 is a code owner automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tzneal @bwagner5