Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Fix termination test panic #2640

Merged
merged 1 commit into from Oct 10, 2022
Merged

test: Fix termination test panic #2640

merged 1 commit into from Oct 10, 2022

Conversation

jonathan-innis
Copy link
Contributor

@jonathan-innis jonathan-innis commented Oct 10, 2022 •
edited

Fixes #

Description

  • Fixes test panic in new race test for termination_controller

How was this change tested?

  • make battletest
  • Tested that test fails with data race without mutex

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note

None

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jonathan-innis jonathan-innis requested a review from a team as a code owner October 10, 2022 17:14
@netlify
Copy link

netlify bot commented Oct 10, 2022 •
edited

✅ Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 2da3f82
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/634453e2f9e56800093858df

tzneal
tzneal previously approved these changes Oct 10, 2022
View reviewed changes
Copy link
Contributor

@tzneal tzneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

tzneal
tzneal approved these changes Oct 10, 2022
View reviewed changes
Copy link
Contributor

@tzneal tzneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jonathan-innis jonathan-innis merged commit f9a641a into aws:main Oct 10, 2022
@jonathan-innis jonathan-innis deleted the fix-termination-test branch October 10, 2022 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzneal tzneal tzneal approved these changes

@bwagner5 bwagner5 Awaiting requested review from bwagner5 bwagner5 is a code owner automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonathan-innis @tzneal