Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Create a cloudprovider.Context and aws.Context to initialize components #2673

Merged
merged 2 commits into from
Oct 19, 2022

Conversation

jonathan-innis
Copy link
Contributor

@jonathan-innis jonathan-innis commented Oct 17, 2022

Fixes #

Description

  • Initializes the cloudprovider using aws.Context which wraps the cloudprovider.Context

How was this change tested?

  • make battletest

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note

None

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@netlify
Copy link

netlify bot commented Oct 17, 2022

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 353c9d6
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/63505ecf41f7600009e790a6

@jonathan-innis jonathan-innis force-pushed the initialize-cloudprovider branch 5 times, most recently from 1615d3e to ebbb195 Compare October 17, 2022 17:01
@jonathan-innis jonathan-innis marked this pull request as ready for review October 17, 2022 17:11
@jonathan-innis jonathan-innis requested a review from a team as a code owner October 17, 2022 17:11
@jonathan-innis jonathan-innis changed the title chore: Create AWS options to initialize components chore: Create AWS context to initialize components Oct 17, 2022
@jonathan-innis jonathan-innis force-pushed the initialize-cloudprovider branch 9 times, most recently from 7b160ee to 9781dce Compare October 18, 2022 22:05
@jonathan-innis jonathan-innis changed the title chore: Create AWS context to initialize components chore: Create a cloudprovider.Context and aws.Context to initialize components Oct 18, 2022
@jonathan-innis jonathan-innis force-pushed the initialize-cloudprovider branch 9 times, most recently from ec8a5bd to f45b34d Compare October 19, 2022 17:29
cmd/controller/main.go Outdated Show resolved Hide resolved
@jonathan-innis jonathan-innis force-pushed the initialize-cloudprovider branch 3 times, most recently from ac8dc8e to 8f1cb0d Compare October 19, 2022 20:31
@jonathan-innis jonathan-innis merged commit 0d86488 into aws:main Oct 19, 2022
@jonathan-innis jonathan-innis deleted the initialize-cloudprovider branch October 19, 2022 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants