Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Migrate launch template provider to use logger context #2686

Merged
merged 1 commit into from
Oct 19, 2022
Merged

chore: Migrate launch template provider to use logger context #2686

merged 1 commit into from
Oct 19, 2022

Conversation

jonathan-innis
Copy link
Contributor

@jonathan-innis jonathan-innis commented Oct 18, 2022 •
edited

Fixes #

Description

  • Migrates logger being instantiated in the constructor to using logging.FromContext(ctx)

How was this change tested?

  • make battletest

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note

None

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jonathan-innis jonathan-innis requested a review from a team as a code owner October 18, 2022 21:48
@netlify
Copy link

netlify bot commented Oct 18, 2022 •
edited

✅ Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 6315066
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/634f1f4c478fa2000914ed7e

njtran
njtran approved these changes Oct 19, 2022
View reviewed changes
Copy link
Contributor

@njtran njtran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM

@jonathan-innis jonathan-innis merged commit 94e7e99 into aws:main Oct 19, 2022
@jonathan-innis jonathan-innis deleted the logger-context-lt branch October 19, 2022 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njtran njtran njtran approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonathan-innis @njtran