fix: cycle through pods multiple times as required when scheduling #2690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for karpenter-docs-prod canceled.
|
This is a minor fix, but allows us to schedule to lager nodes in the case where pods have inter-dependencies that can be satisfied as long as they are scheduled in the correct order. There was a test for this, but the test was incorrect in that it didn't actually verify that the pods scheduled.
tzneal
force-pushed
the
fix-schedule-issue
branch
from
a2e069e
to
b461cc3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a minor fix, but allows us to schedule to lager nodes in the case where pods have inter-dependencies that can be satisfied as long as they are scheduled in the correct order. There was a test for this, but the test was incorrect in that it didn't actually verify that the pods scheduled.
How was this change tested?
Does this change impact docs?
Release Note
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.