Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate utils #2698

Merged
merged 1 commit into from
Oct 20, 2022
Merged

chore: migrate utils #2698

merged 1 commit into from
Oct 20, 2022

Conversation

ellistarn
Copy link
Contributor

Fixes #

Description

  • Decouple AddToScheme for AWS APIs and Core APIs
  • Fixes an issue with ginkgo.ginkgoRecover() in the testenv cleanup

How was this change tested?

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ellistarn ellistarn requested a review from a team as a code owner October 19, 2022 18:59
@ellistarn ellistarn requested a review from dewjam October 19, 2022 18:59
@netlify
Copy link

netlify bot commented Oct 19, 2022

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 24db05f
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/63506d5fbb07ec00086110b2

Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@ellistarn ellistarn merged commit fdd2640 into aws:main Oct 20, 2022
@ellistarn ellistarn deleted the test branch October 20, 2022 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants