Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add doc-gen to a post CI test #2699

Merged
merged 2 commits into from
Oct 19, 2022
Merged

Add doc-gen to a post CI test #2699

merged 2 commits into from
Oct 19, 2022

Conversation

spring1843
Copy link
Contributor

Fixes #

Description

How was this change tested?

  • Runs make docgen after a successful run of CI
  • Should help find out if a change broke make docgen

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@spring1843 spring1843 requested a review from a team as a code owner October 19, 2022 20:15
@netlify
Copy link

netlify bot commented Oct 19, 2022

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit dcf18a1
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/63505afd30b0220008c207d8

Copy link
Contributor

@tzneal tzneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm


jobs:
stable-release:
if: github.event.workflow_run.conclusion == 'success' && github.repository == 'aws/karpenter'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason it should just run on completion? Just to reduce the number of API calls?

@spring1843 spring1843 merged commit d26cf44 into aws:main Oct 19, 2022
@spring1843 spring1843 deleted the rm/add-doc-gen-test branch October 19, 2022 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants