Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: decouple scheme #2708

Merged
merged 1 commit into from
Oct 20, 2022
Merged

chore: decouple scheme #2708

merged 1 commit into from
Oct 20, 2022

Conversation

ellistarn
Copy link
Contributor

@ellistarn ellistarn commented Oct 20, 2022 •
edited

Fixes #

Description

How was this change tested?

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ellistarn ellistarn requested a review from a team as a code owner October 20, 2022 17:36
@ellistarn ellistarn requested a review from dewjam October 20, 2022 17:36
@netlify
Copy link

netlify bot commented Oct 20, 2022 •
edited

✅ Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 4d6a994
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/6351899c97f80000083c4740

jonathan-innis
jonathan-innis approved these changes Oct 20, 2022
View reviewed changes
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@ellistarn ellistarn merged commit 6ba8044 into aws:main Oct 20, 2022
@ellistarn ellistarn deleted the scheme branch October 20, 2022 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathan-innis jonathan-innis jonathan-innis approved these changes

@dewjam dewjam Awaiting requested review from dewjam dewjam is a code owner automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ellistarn @jonathan-innis