Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix ipv6 tests by removing custom test ami #2742

Merged
merged 1 commit into from
Oct 27, 2022
Merged

test: fix ipv6 tests by removing custom test ami #2742

merged 1 commit into from
Oct 27, 2022

Conversation

bwagner5
Copy link
Contributor

Fixes #

Description

  • Fixes the IPv6 e2e tests. I was using a custom built AMI to test the tests before the ipv6 bootstrap changes were released in the EKS Optimized AMI and forgot to remove :\

How was this change tested?

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@bwagner5 bwagner5 requested a review from a team as a code owner October 27, 2022 14:06
@bwagner5 bwagner5 requested a review from dewjam October 27, 2022 14:06
@netlify
Copy link

netlify bot commented Oct 27, 2022 •
edited

✅ Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit aa6f894
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/635a90527114ec00088da932

jonathan-innis
jonathan-innis approved these changes Oct 27, 2022
View reviewed changes
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jonathan-innis jonathan-innis merged commit 1493360 into aws:main Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathan-innis jonathan-innis jonathan-innis approved these changes

@dewjam dewjam Awaiting requested review from dewjam dewjam is a code owner automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bwagner5 @jonathan-innis