Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix REST config injection in cloudprovider #2744

Merged
merged 1 commit into from
Oct 27, 2022

Conversation

jonathan-innis
Copy link
Contributor

@jonathan-innis jonathan-innis commented Oct 27, 2022

Fixes #

Description

  • RESTConfig was not injected into cloudprovider context which was causing getCABundle to return nothing

This is a buddy PR for karpenter-core: kubernetes-sigs/karpenter#38

How was this change tested?

  • make test

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note

None

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jonathan-innis jonathan-innis requested a review from a team as a code owner October 27, 2022 14:58
@netlify
Copy link

netlify bot commented Oct 27, 2022

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit bc68d1c
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/635aa2e15664b2000afa1b24

@jonathan-innis jonathan-innis force-pushed the fix-rest-config branch 2 times, most recently from 90fe92e to 75bddec Compare October 27, 2022 15:24
Copy link
Contributor

@dewjam dewjam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonathan-innis jonathan-innis merged commit 3da2172 into aws:main Oct 27, 2022
@jonathan-innis jonathan-innis deleted the fix-rest-config branch October 27, 2022 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants