fix: use upgrade Go in the tools image #2749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for karpenter-docs-prod canceled.
|
| @@ -30,10 +30,11 @@ RUN apk add --no-cache \ | |||
| curl \ | |||
| tar \ | |||
| bash \ | |||
| gcc \ | |||
There was a problem hiding this comment.
Have we tried to resolve the dependency issue with CGO rather than adding the gcc directly to the Dockerfile?
There was a problem hiding this comment.
There was a problem hiding this comment.
Line linking is broken. Look at the top line of the file.
There was a problem hiding this comment.
@jonathan-innis no, but this image should reflect what's being used regardless. We have to find out which dependency is using CGO now (It's probably knative) and see if we can do anything about it.
ellistarn
approved these changes
Oct 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Description
Latest alpine has Go 1.18 while we need 1.19
Also adds gcc and common libraries so that dependencies that use CGO can build
How was this change tested?
Does this change impact docs?
Release Note
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.