chore: Separated webhooks from karpenter-core #2754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for karpenter-docs-prod canceled.
|
ellistarn
force-pushed
the
webhooks
branch
2 times, most recently
from
6bda3ae
to
5cb040a
Compare
ellistarn
commented
Oct 28, 2022
ellistarn
force-pushed
the
webhooks
branch
4 times, most recently
from
61c40ff
to
3854f56
Compare
ellistarn
force-pushed
the
webhooks
branch
4 times, most recently
from
4b9b9dc
to
892a9a1
Compare
ellistarn
commented
Oct 28, 2022
| @@ -103,8 +102,13 @@ delete: ## Delete the controller from your ~/.kube/config cluster | |||
| helm uninstall karpenter --namespace karpenter | |||
|
|
|||
| codegen: ## Generate code. | |||
| curl https://raw.githubusercontent.com/aws/karpenter-core/v0.0.1/chart/crds/karpenter.sh_provisioners.yaml > charts/karpenter/crds/karpenter.sh_provisioners.yaml | |||
| controller-gen \ | |||
There was a problem hiding this comment.
Somehow this got lost from karpenter's release processes 🤔
ellistarn
commented
Oct 28, 2022
| @@ -0,0 +1,70 @@ | |||
| apiVersion: rbac.authorization.k8s.io/v1 | |||
There was a problem hiding this comment.
karpenter and karpenter-core charts will be split/renamed in a followon.
ellistarn
force-pushed
the
webhooks
branch
10 times, most recently
from
b5f0a31
to
1c2dcb7
Compare
ellistarn
force-pushed
the
webhooks
branch
2 times, most recently
from
6fe7cb0
to
5ab0a07
Compare
ellistarn
force-pushed
the
webhooks
branch
3 times, most recently
from
bc2fa61
to
a8e164a
Compare
jonathan-innis
requested changes
Oct 31, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Description
How was this change tested?
Does this change impact docs?
Release Note
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.