Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add reusability to work flows, reuse for caching, and authentication #2762

Merged
merged 6 commits into from
Nov 1, 2022
Merged

fix: Add reusability to work flows, reuse for caching, and authentication #2762

merged 6 commits into from
Nov 1, 2022

Conversation

spring1843
Copy link
Contributor

Fixes #

Description

  • Adds re-usable actions to Github workflows for caching and authentication
  • Uniform caching should help us always cache the same way, should speed up the long make toolchain command in CI and other workflows saving us a few minutes in each run
  • Reusing the authentication should make developer experience easier by having to change only one file while testing
  • Rename all .yaml files to .yaml

How was this change tested?

  • On a fork

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@spring1843 spring1843 requested a review from a team as a code owner November 1, 2022 01:01
@netlify
Copy link

netlify bot commented Nov 1, 2022

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 91b4005
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/6360702ef0fc4900082f61f2

@spring1843 spring1843 enabled auto-merge (squash) November 1, 2022 01:03
using: "composite"
steps:
- run: sed -En 's/^go[[:space:]]+([[:digit:].]+)$/GO_VERSION=\1/p' go.mod >> $GITHUB_ENV
shell: bash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's this bit for? Is there a different default shell?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's just required in composite actions.

Copy link
Contributor

@ellistarn ellistarn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@spring1843 spring1843 merged commit c156512 into aws:main Nov 1, 2022
@spring1843 spring1843 deleted the rm/reuse-cache branch November 2, 2022 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants