Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Always print test logs, even if cleanup fails #2778

Merged
merged 1 commit into from
Nov 1, 2022
Merged

test: Always print test logs, even if cleanup fails #2778

merged 1 commit into from
Nov 1, 2022

Conversation

jonathan-innis
Copy link
Contributor

@jonathan-innis jonathan-innis commented Nov 1, 2022 •
edited

Fixes #

Description

  • Always prints test logs now since log dump is in a separate AfterEach block
  • Always do ForceCleanup to avoid test pollution

How was this change tested?

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note

None

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jonathan-innis jonathan-innis requested a review from a team as a code owner November 1, 2022 17:55
@netlify
Copy link

netlify bot commented Nov 1, 2022 •
edited

✅ Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 0ddb64a
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/636164c5f6f3d200089779b9

@jonathan-innis jonathan-innis force-pushed the always-print-logs branch 3 times, most recently from e9ff6d5 to 818a887 Compare November 1, 2022 18:25
njtran
njtran approved these changes Nov 1, 2022
View reviewed changes
Copy link
Contributor

@njtran njtran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just two nits

test/pkg/environment/aws/setup.go Show resolved Hide resolved
test/pkg/environment/common/setup.go Show resolved Hide resolved
@jonathan-innis jonathan-innis merged commit 66dd810 into aws:main Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njtran njtran njtran approved these changes

@dewjam dewjam Awaiting requested review from dewjam dewjam is a code owner automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonathan-innis @njtran