BREAKING CHANGE: Move instance type filtering from implicit to explicit at defaulting time #2779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for karpenter-docs-prod canceled.
|
ellistarn
changed the title
bwagner5
reviewed
Nov 1, 2022
ellistarn
force-pushed
the
defaults
branch
5 times, most recently
from
83a87f4
to
8f29fb9
Compare
bwagner5
requested changes
Nov 1, 2022
| @@ -98,7 +98,8 @@ By adopting this practice we allow our users who are early adopters to test out | |||
| # Released Upgrade Notes | |||
|
|
|||
| ## Upgrading to v0.19.0+ | |||
| * v0.19.0 combines the karpenter webhook and controller containers into a single binary, which requires changes to the helm chart. If your Karpenter installation (helm or otherwise) currently customizes the karpenter webhook, your deployment tooling may require minor changes. | |||
| * The karpenter webhook and controller containers are combined into a single binary, which requires changes to the helm chart. If your Karpenter installation (helm or otherwise) currently customizes the karpenter webhook, your deployment tooling may require minor changes. | |||
| * Instance category defaults are now explicitly persisted in the Provisioner, rather than handled implicitly in memory. By default, Provisioners will limit instance category to c,m,r. If any instance type constraints are applied, it will override this default. If you have created Provisioners in the past with unconstrained instance type, family, or category, Karpenter will now more flexibly use instance types than before. If you would like to apply these constraints, they must be included in the Provisioner CRD. | |||
There was a problem hiding this comment.
are arm instances excluded then?
cause those are g
There was a problem hiding this comment.
c6g, etc are of category c: https://karpenter.sh/v0.18.1/aws/instance-types/#c6g-family
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Description
This change will force a minor version bump as specified in https://karpenter.sh/docs/upgrade-guide/
Instance category defaults are now explicitly persisted in the Provisioner, rather than handled implicitly in memory. By default, Provisioners will limit instance category to c,m,r. If any instance type constraints are applied, it will override this default. If you have created Provisioners in the past with unconstrained instance type, family, or category, Karpenter will now more flexibly use instance types than before. If you would like to apply these constraints, they must be included in the Provisioner CRD.
This also helps to decouple instance type from provisioner, enabling upcoming work.
How was this change tested?
make testDoes this change impact docs?
Release Note
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.