Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: increase instance type flexibility on each fleet call #2814

Merged
merged 1 commit into from
Nov 8, 2022
Merged

feat: increase instance type flexibility on each fleet call #2814

merged 1 commit into from
Nov 8, 2022

Conversation

bwagner5
Copy link
Contributor

@bwagner5 bwagner5 commented Nov 7, 2022

Fixes #
#2721

Description

  • Increase the flexibility of instance type options passed to each EC2 Fleet call.

How was this change tested?

  • scaled out a flexible pod and checked cloudtrail for the fleet request. It successfully added 180 instance types (60*3 AZs)

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@bwagner5 bwagner5 requested a review from a team as a code owner November 7, 2022 19:02
@bwagner5 bwagner5 requested a review from njtran November 7, 2022 19:02
@netlify
Copy link

netlify bot commented Nov 7, 2022 •
edited

✅ Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit d1cfe95
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/636956424cdf8900083de82a
😎 Deploy Preview https://deploy-preview-2814--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

jonathan-innis
jonathan-innis approved these changes Nov 7, 2022
View reviewed changes
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@bwagner5 bwagner5 merged commit dea7310 into aws:main Nov 8, 2022
@bwagner5 bwagner5 deleted the inc-it-opts branch November 8, 2022 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ellistarn ellistarn ellistarn approved these changes

@jonathan-innis jonathan-innis jonathan-innis approved these changes

@njtran njtran Awaiting requested review from njtran njtran is a code owner automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bwagner5 @ellistarn @jonathan-innis