test: removed test to add back in later #2824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for karpenter-docs-prod canceled.
|
jonathan-innis
requested changes
Nov 9, 2022
| env.ExpectInstance(pod.Spec.NodeName).To(HaveField("ImageId", HaveValue(Equal(customAMI)))) | ||
| }) | ||
| // TODO @njtran add back in | ||
| // It("should use the most recent AMI when discovering multiple", func() { |
There was a problem hiding this comment.
Can we use the Ginkgo Skip function rather than commenting this out?
jonathan-innis
approved these changes
Nov 9, 2022
|
Let's hold off, I have a fix. #2826 |
bwagner5
added a commit
to bwagner5/karpenter
that referenced
this pull request
Nov 9, 2022
This reverts commit 198f3b3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Description
Test was flaking.
Test relies on the SSM alias for the recommended EKS Optimized AMI but rather than referring to a previous release, just decrements the kubernetes version. These all have the CreationTimestamp as the same, so it doesn't always succeed.
How was this change tested?
Does this change impact docs?
Release Note
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.