Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing DELETE method for validating webhook #2891

Merged
merged 2 commits into from
Nov 21, 2022

Conversation

skdltmxn
Copy link
Contributor

Fixes #

Description

Minor fix for validation.webhook.karpenter.k8s.aws webhook.
It seems like DELETE method for karpenter.k8s.aws group was removed in #2754.
I see no reason for the deletion, and think it was a mistake.

How was this change tested?

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@skdltmxn skdltmxn requested a review from a team as a code owner November 19, 2022 12:01
@skdltmxn skdltmxn requested a review from njtran November 19, 2022 12:01
@netlify
Copy link

netlify bot commented Nov 19, 2022

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 3985f38
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/637b2872760b010009c8c088

@ellistarn
Copy link
Contributor

I don't see the usecase for validating delete requests. Can't remember, but probably why I removed it. Does this break something?

@skdltmxn
Copy link
Contributor Author

I don't see the usecase for validating delete requests. Can't remember, but probably why I removed it. Does this break something?

I am currently running two EKS clusters with karpenter.
I used helm to install karpenter, but directly installed it using helm cli on one cluster and argocd installed on the another.

On both clusters, deployed webhooks have DELETE method unlike the template. It is fine on cluster where I used helm cli, but on cluster with argocd it seems argocd is constantly re-syncing the webhook. This makes karpenter pods emit reconcile errors every few second and no node is spawned.

I still don't understand why deployed webhooks get DELETE method back again, but so far I believe this PR could fix current problem.

@ellistarn
Copy link
Contributor

I think this is due to knative's webhook reconciliation behavior. Fix SGTM

@ellistarn ellistarn merged commit cd5bb50 into aws:main Nov 21, 2022
@skdltmxn skdltmxn deleted the missing-delete-for-webhook branch November 22, 2022 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants