Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use Spot capacity-optimized-prioritized in China regions until price-capacity-optimized is launched there #2900

Merged
merged 1 commit into from
Nov 21, 2022

Conversation

bwagner5
Copy link
Contributor

Fixes #
#2896

Description

  • The price-capacity-optimized allocation strategy for Spot has not been launched in China regions yet, so revert to using capacity-optimized-prioritized until it is launched.

How was this change tested?

  • Deployed to EKS Cluster in us-east-2, verified in CloudTrail that price-capacity-optimized was being used. Changed the strings.HasPrefix calls to use "us-" instead of "cn-" and redeployed. Observed CreateFleet requests in CloudTrail using capacity-optimized-prioritized with Priorities assigned in the requests.

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@bwagner5 bwagner5 requested a review from a team as a code owner November 21, 2022 17:42
@netlify
Copy link

netlify bot commented Nov 21, 2022

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 388c472
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/637bba69b55ead0009c23775

ellistarn
ellistarn previously approved these changes Nov 21, 2022
Copy link
Contributor

@tzneal tzneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorted by price and not vcpu/memory, but no big deal. Lgtm.

@bwagner5 bwagner5 merged commit 470aa83 into aws:main Nov 21, 2022
@bwagner5 bwagner5 deleted the cn-no-pco branch November 21, 2022 18:46
bwagner5 added a commit to bwagner5/karpenter that referenced this pull request Jan 4, 2023
… until price-capacity-optimized is launched there (aws#2900)"

This reverts commit 470aa83.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants