Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix metrics default port #4071

Merged
merged 2 commits into from
Jun 19, 2023
Merged

docs: fix metrics default port #4071

merged 2 commits into from
Jun 19, 2023

Conversation

njtran
Copy link
Contributor

@njtran njtran commented Jun 16, 2023

Fixes #4066

Description
Karpenter's default metrics port was changed as part of v0.28.0, but the docs didn't reflect this change.

How was this change tested?

  • make website

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@njtran njtran requested a review from a team as a code owner June 16, 2023 18:20
@njtran njtran requested a review from ellistarn June 16, 2023 18:20
@netlify
Copy link

netlify bot commented Jun 16, 2023

Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit cdee58d
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/6490aa1763108d0007a3b3d3
😎 Deploy Preview https://deploy-preview-4071--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

bwagner5
bwagner5 previously approved these changes Jun 16, 2023
Copy link
Contributor

@bwagner5 bwagner5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@njtran njtran merged commit 0e3812c into aws:main Jun 19, 2023
13 checks passed
JamesGAWS pushed a commit to JamesGAWS/karpenter that referenced this pull request Jun 20, 2023
@njtran njtran deleted the fixdefault branch December 26, 2023 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Metrics Port in the Helm Chart does not match Documentation
3 participants