Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make logging more clear for interruption delete #4079

Merged
merged 2 commits into from
Jun 19, 2023

Conversation

njtran
Copy link
Contributor

@njtran njtran commented Jun 19, 2023

Fixes #4028

Description
Changes interruption delete message to show that delete has been initiated, but hasn't actually finished.

How was this change tested?

  • make presubmit

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@njtran njtran requested a review from a team as a code owner June 19, 2023 20:05
@njtran njtran requested a review from engedaam June 19, 2023 20:05
@netlify
Copy link

netlify bot commented Jun 19, 2023

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 68ae362
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/6490ba566e44a70008bb53e2

Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@njtran njtran enabled auto-merge (squash) June 19, 2023 20:28
@njtran njtran merged commit 4f0795b into aws:main Jun 19, 2023
12 checks passed
JamesGAWS pushed a commit to JamesGAWS/karpenter that referenced this pull request Jun 20, 2023
@njtran njtran deleted the interruptionDocs branch December 26, 2023 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How should interruption-handling really work?
2 participants