Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add GetTemplateSummary permission & fix upgrade #4089

Merged
merged 3 commits into from
Jun 20, 2023
Merged

chore: Add GetTemplateSummary permission & fix upgrade #4089

merged 3 commits into from
Jun 20, 2023

Conversation

jonathan-innis
Copy link
Contributor

@jonathan-innis jonathan-innis commented Jun 20, 2023 •
edited

Fixes #

Description

  • Adds the cloudformation:GetTemplateSummary permission for evaluating cluster upgrade in upgrade testing
  • Adds a separate checkout step for checking out the actions from the updated git ref

How was this change tested?

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@netlify
Copy link

netlify bot commented Jun 20, 2023 •
edited

✅ Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 9ed86a6
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/64922718818daa0008c0e455

@jonathan-innis jonathan-innis changed the title chore: Add GetTemplateSummary permission to upgrade chore: Add GetTemplateSummary permission & fix upgrade Jun 20, 2023
jonathan-innis
jonathan-innis commented Jun 20, 2023
View reviewed changes
Copy link
Contributor Author

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

@github-actions
Copy link
Contributor

Snapshot successfully published to oci://public.ecr.aws/karpenter/karpenter:v0-a3b8a6078cfaf50528f4df560712e93be599a21d. Find the image tag and installation instructions at https://gallery.ecr.aws/karpenter/karpenter/

jonathan-innis
jonathan-innis commented Jun 20, 2023
View reviewed changes
Copy link
Contributor Author

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

@github-actions
Copy link
Contributor

Snapshot successfully published to oci://public.ecr.aws/karpenter/karpenter:v0-9ed86a6e2546a932c5926bbbf87b68bdc7fac625. Find the image tag and installation instructions at https://gallery.ecr.aws/karpenter/karpenter/

@jonathan-innis jonathan-innis marked this pull request as ready for review June 20, 2023 23:13
@jonathan-innis jonathan-innis requested a review from a team as a code owner June 20, 2023 23:13
@jonathan-innis jonathan-innis enabled auto-merge (squash) June 20, 2023 23:13
@jonathan-innis jonathan-innis merged commit 63f76f3 into aws:main Jun 20, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@engedaam engedaam engedaam approved these changes

@bwagner5 bwagner5 Awaiting requested review from bwagner5 bwagner5 is a code owner automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonathan-innis @engedaam