Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Fix k8s_version value in create-cluster and Matching " #4111

Merged
merged 2 commits into from
Jun 22, 2023

Conversation

jonathan-innis
Copy link
Contributor

@jonathan-innis jonathan-innis commented Jun 22, 2023

Fixes #N/A

Description

  • Fixes syntax error in create-cluster with missing " character
  • Uses the inputs.k8s_version value instead of the old kubernetes_version value

How was this change tested?

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jonathan-innis jonathan-innis requested a review from a team as a code owner June 22, 2023 20:36
@netlify
Copy link

netlify bot commented Jun 22, 2023

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 664206d
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/6494b27d582eb00008581946

Copy link
Contributor Author

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

@github-actions
Copy link
Contributor

Snapshot successfully published to oci://public.ecr.aws/karpenter/karpenter:v0-70ae632eb7a33974a276dd7c2a9bf0bb8866c69c. Find the image tag and installation instructions at https://gallery.ecr.aws/karpenter/karpenter/

Copy link
Contributor Author

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

@jonathan-innis jonathan-innis changed the title test: Fix k8s version value in create-cluster test: Fix k8s_version value in create-cluster and Matching " Jun 22, 2023
@jonathan-innis jonathan-innis enabled auto-merge (squash) June 22, 2023 20:45
@github-actions
Copy link
Contributor

Snapshot successfully published to oci://public.ecr.aws/karpenter/karpenter:v0-664206df0bb0b507cc7681bfb7fec3ed5d0a0da7. Find the image tag and installation instructions at https://gallery.ecr.aws/karpenter/karpenter/

@jonathan-innis jonathan-innis merged commit d7f701b into aws:main Jun 22, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants