Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Updated latest release version to v0.28.1 #4112

Merged
merged 2 commits into from
Jun 22, 2023
Merged

Conversation

ellistarn
Copy link
Contributor

@ellistarn ellistarn commented Jun 22, 2023

Fixes #N/A

Description

Our docs process is broken for cherry-picked patch releases. I had to do this manually πŸ‘¨β€πŸ³

How was this change tested?

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ellistarn ellistarn requested a review from a team as a code owner June 22, 2023 21:09
@ellistarn ellistarn requested a review from tzneal June 22, 2023 21:09
@netlify
Copy link

netlify bot commented Jun 22, 2023

βœ… Deploy Preview for karpenter-docs-prod ready!

Name Link
πŸ”¨ Latest commit b2668f4
πŸ” Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/6494bd5066b3dd0008d6ebc0
😎 Deploy Preview https://deploy-preview-4112--karpenter-docs-prod.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are all these docs changes supposed to go in since the v0.28.1 should just have the single commit? I think you mainly just need to update the latest release version in the patch version update

Copy link
Contributor

@bwagner5 bwagner5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ellistarn ellistarn merged commit 16cf151 into aws:main Jun 22, 2023
13 checks passed
@bwagner5
Copy link
Contributor

Are all these docs changes supposed to go in since the v0.28.1 should just have the single commit? I think you mainly just need to update the latest release version in the patch version update

the minor version docs are static now, so these updates are needed. latest-release only affects preview now. We need to get rid of /docs/ (got distracted and haven't tried the symlink yet) and then this will be a little more straight forward (less changes at least).

@ellistarn ellistarn deleted the ptr branch June 23, 2023 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants